Skip to content
This repository was archived by the owner on Oct 6, 2024. It is now read-only.

Conversation

@lehuuphuocct123
Copy link
Contributor

No description provided.

@lehuuphuocct123
Copy link
Contributor Author

Hi @gomzyakov, I have an assignment in my school to solve any issue labeled "good-first-issue" and I found the issue Replace favicons on the site in your repository. Could you review whether my pull request suits your requirements?

@codecov
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c866d38) 3.50% compared to head (6e430a5) 3.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##              main     #52   +/-   ##
=======================================
  Coverage     3.50%   3.50%           
  Complexity      31      31           
=======================================
  Files            5       5           
  Lines          114     114           
=======================================
  Hits             4       4           
  Misses         110     110           
Flag Coverage Δ
unittests 3.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gomzyakov gomzyakov merged commit ecd5c09 into gomzyakov:main Nov 1, 2023
@gomzyakov
Copy link
Owner

@lehuuphuocct123

Thanks for the work you've done!

It’s cool that you are given such tasks at school. In what region is this school located?

@lehuuphuocct123
Copy link
Contributor Author

@gomzyakov, my school in Vietnam ^^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants