This repository was archived by the owner on Nov 24, 2018. It is now read-only.
Adddlarf #15
Merged
Adddlarf #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This routine is used as a kernel for many other Lapack routines. It works toward linear solve and symmetric eigenvalues. I thought about changing iladlr and iladlc to return the 1-indexed row which would make the code cleaner. However, according to the call graph at http://www.netlib.org/lapack/explore-html/d5/d87/iladlr_8f.html#a98b05d45e20605b554f65db26470d079 , this routine is only used by dlarf. For the single case of improvement, it didn't seem worth the confusion in behavior difference. |
Member
There was a problem hiding this comment.
Do we want to add a package-level doc comment at this stage?
Member
Author
There was a problem hiding this comment.
Yes. I think that's a good idea. I'll make a new commit for it though.
Member
|
LGTM with very minor comments. |
Added dlarf, tests, some auxiliary routines, and missing license headers PR comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.