This repository was archived by the owner on Nov 24, 2018. It is now read-only.
Add dgetrf and tests #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Wrong about something. Fixing. |
Member
Author
|
Okay. Fixed. PTAL @kortschak |
Member
Author
|
OpenBLAS tests pass on my machine. |
Member
There was a problem hiding this comment.
Can we reflect this comment in the native location as well - I should have done that.
Member
Author
There was a problem hiding this comment.
Ah, oops. I had this in at one point as well.
Member
|
LGTM with minor comments. |
removed unnecessary requirement Implement Dlaswp in both directions Responded to PR comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.