This repository was archived by the owner on Nov 24, 2018. It is now read-only.
Add LQ factorization to cgo and tests #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The Dgetrs cases were modified to increase the robustness of the test. With the previous tolerances, the tests pass without Dgelqf and Dgelq2 tests. They also pass if both TestDgelqf and TestDgelq are included. They don't pass if exactly one are included. My guess is that it's just slight differences in random numbers. |
cgo/lapack.go
Outdated
Member
|
LGTM with minor comments. |
Responded to PR comments
btracey
added a commit
that referenced
this pull request
Aug 4, 2015
Add LQ factorization to cgo and tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.