This repository was archived by the owner on Nov 24, 2018. It is now read-only.
Add drscl and tests, and fix the dlamch parameters while here. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The tests reach all three code paths in the for loop. |
native/general.go
Outdated
Member
There was a problem hiding this comment.
It's a pity the binary exponent form was removed from the language.
Member
Author
There was a problem hiding this comment.
This is the first I've heard about it ever being in the language.
Member
There was a problem hiding this comment.
It's not anymore. It was removed for 1.5. It's used by the compiler and not specified, so they removed it.
Member
|
LGTM with minor comments. |
btracey
added a commit
that referenced
this pull request
Sep 5, 2015
Add drscl and tests, and fix the dlamch parameters while here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.