Skip to content
This repository was archived by the owner on Nov 24, 2018. It is now read-only.

Conversation

@btracey
Copy link
Member

@btracey btracey commented Sep 8, 2015

No description provided.

@kortschak
Copy link
Member

That time-out during TestDgetrs is something I've seen before - I don't understand why the cgo tests take so long (the native tests are typically under ~10s for the long running ones here):

=== RUN TestDlange-2
--- PASS: TestDlange-2 (0.04 seconds)
=== RUN TestDpotrf-2
--- PASS: TestDpotrf-2 (6.29 seconds)
=== RUN TestDgecon-2
--- PASS: TestDgecon-2 (0.00 seconds)
=== RUN TestDgelq2-2
--- PASS: TestDgelq2-2 (0.00 seconds)
=== RUN TestDgels-2
--- PASS: TestDgels-2 (266.43 seconds)
=== RUN TestDgelqf-2
--- PASS: TestDgelqf-2 (105.36 seconds)
=== RUN TestDgeqr2-2
--- PASS: TestDgeqr2-2 (0.00 seconds)
=== RUN TestDgeqrf-2
--- PASS: TestDgeqrf-2 (87.53 seconds)
=== RUN TestDgetf2-2
--- PASS: TestDgetf2-2 (0.00 seconds)
    dgetf2.go:97: Returned ok with singular matrix.
    dgetf2.go:97: Returned ok with singular matrix.
=== RUN TestDgetrf-2
--- PASS: TestDgetrf-2 (28.46 seconds)
=== RUN TestDgetrs-2
SIGQUIT: quit
PC=0x555923
[snip]
*** Test killed with quit: ran too long (10m0s).

native/dgecon.go Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work will not panic - "and Dgecon will panic otherwise."

Also below.

@btracey
Copy link
Member Author

btracey commented Sep 9, 2015

Does that ever happen to you locally? For me the full native suite runs in about 10s and the cgo suite runs in about 4.

@kortschak
Copy link
Member

Never happens to me. I think it is something to do with Travis hardware and the way they deal with floats, but I have no evidence for that.

This LGTM with minor comments. Much clearer than the fortran which manages to make spaghetti out of 50 line routine.

btracey added a commit that referenced this pull request Sep 9, 2015
Add Dgecon and tests, plus small fix to Dlacn2
@btracey btracey merged commit c34058b into master Sep 9, 2015
@btracey btracey deleted the adddgecon branch September 9, 2015 04:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants