This repository was archived by the owner on Nov 23, 2018. It is now read-only.
Swap arguments to Grad and Hess #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-ch
force-pushed
the
swap-grad-args
branch
from
fd56b20 to
0f8ab0b
Compare
types.go
Outdated
There was a problem hiding this comment.
Can we change this to MutableSym while we're breaking everything?
There was a problem hiding this comment.
AFAICT we don't have MutableSym (yet).
There was a problem hiding this comment.
Argh ... and @kortschak complains that he says foolish things ...
|
LGTM with the interface change. |
vladimir-ch
force-pushed
the
swap-grad-args
branch
from
0f8ab0b to
da311b7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@btracey PTAL