Skip to content

feat: switch to using actions-utils #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2021
Merged

feat: switch to using actions-utils #243

merged 1 commit into from
Dec 23, 2021

Conversation

@sethvargo
Copy link
Contributor

@sethvargo sethvargo commented Dec 21, 2021

No description provided.

@sethvargo sethvargo requested a review from a team as a code owner December 21, 2021 22:56
@sethvargo sethvargo enabled auto-merge (squash) December 21, 2021 22:59
bharathkkb
bharathkkb approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deploy-cloud-functions/src/main.ts

Line 119 in 8039028

if (dockerRepository || kmsKeyName) {
looks like a good candidate for allOf.

@sethvargo
Copy link
Contributor Author

sethvargo commented Dec 23, 2021

LGTM

deploy-cloud-functions/src/main.ts

Line 119 in 8039028

if (dockerRepository || kmsKeyName) {

looks like a good candidate for allOf.

I'm not really sure the best way to use allOf that doesn't make returning a detailed error message harder 😦

@sethvargo sethvargo merged commit 938f2f6 into main Dec 23, 2021
@sethvargo sethvargo deleted the sethvargo/utils branch December 23, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch Awaiting requested review from averikitsch averikitsch is a code owner automatically assigned from google-github-actions/maintainers

1 more reviewer

@bharathkkb bharathkkb bharathkkb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sethvargo @bharathkkb