Skip to content

Fix Objc Sample App Build failure #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Fix Objc Sample App Build failure #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Samples/ObjC/SignInSample/Source/AppDelegate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ - (BOOL)application:(UIApplication *)application
// succeeds, we'll have a currentUser and the view will be able to draw its UI for the signed-in
// state. If the restore fails, currentUser will be nil and we'll draw the signed-out state
// prompting the user to sign in.
[GIDSignIn.sharedInstance restorePreviousSignInWithCallback:^(GIDGoogleUser * _Nullable user,
NSError * _Nullable error) {
[GIDSignIn.sharedInstance restorePreviousSignInWithCompletion:^(GIDGoogleUser *user,
NSError *error) {
self.window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]];
SignInViewController *masterViewController =
[[SignInViewController alloc] initWithNibName:@"SignInViewController" bundle:nil];
Expand Down
8 changes: 3 additions & 5 deletions Samples/ObjC/SignInSample/Source/SignInViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,7 @@ - (void)updateButtons {
- (IBAction)signIn:(id)sender {
[GIDSignIn.sharedInstance signInWithConfiguration:_configuration
presentingViewController:self
callback:^(GIDGoogleUser * _Nullable user,
NSError * _Nullable error) {
completion:^(GIDGoogleUser *user, NSError *error) {
if (error) {
self->_signInAuthStatus.text =
[NSString stringWithFormat:@"Status: Authentication error: %@", error];
Expand All @@ -278,7 +277,7 @@ - (IBAction)signOut:(id)sender {
}

- (IBAction)disconnect:(id)sender {
[GIDSignIn.sharedInstance disconnectWithCallback:^(NSError * _Nullable error) {
[GIDSignIn.sharedInstance disconnectWithCompletion:^(NSError *error) {
if (error) {
self->_signInAuthStatus.text = [NSString stringWithFormat:@"Status: Failed to disconnect: %@",
error];
Expand All @@ -293,8 +292,7 @@ - (IBAction)disconnect:(id)sender {
- (IBAction)addScopes:(id)sender {
[GIDSignIn.sharedInstance addScopes:@[ @"https://www.googleapis.com/auth/user.birthday.read" ]
presentingViewController:self
callback:^(GIDGoogleUser * _Nullable user,
NSError * _Nullable error) {
completion:^(GIDGoogleUser *user, NSError *error) {
if (error) {
self->_signInAuthStatus.text = [NSString stringWithFormat:@"Status: Failed to add scopes: %@",
error];
Expand Down