Ignore warnings from GTMFetcherAuthorizationProtocol deprecation #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmathias
reviewed
Sep 13, 2022
Collaborator
mdmathias
left a comment
mdmathias
left a comment
There was a problem hiding this comment.
Should we update GTMAppAuth to conform to GTMSessionFetcherAuthorizer so that we don't need to worry about the deprecation of GTMFetcherAuthorizationProtocol?
I guess that change would require a major version release of GTMAppAuth?
Contributor
Author
We should consider this for our next major release of GTMAppAuth. We'll have to decide if we're comfortable dropping support for anything before GTMSessionFetcher 2.1.0. |
mdmathias
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of GTMAppAuth 1.3.1, we're now building against GTMSessionFetcher 2.1.x by default and need to handle warnings stemming from the deprecation of
GTMFetcherAuthorizationProtocol.