Skip to content

Conversation

@petea
Copy link
Contributor

@petea petea commented Nov 1, 2022

This addresses three issues:

  • The pull_request trigger is currently scoped to main branch only, so jobs aren't run by default for PRs on feature branches.
  • Warnings about themacOS-latest runner alias transitioning from macOS-11 to macOS-12.
  • Integration tests failing when triggered by a PR from a fork due to the secret not being passed to the runner in this scenario.

@petea petea marked this pull request as ready for review November 1, 2022 19:27
@petea petea requested review from Alex-4-Git and mdmathias November 1, 2022 19:27
@Alex-4-Git
Copy link
Contributor

Provide some descriptions.

@petea
Copy link
Contributor Author

petea commented Nov 1, 2022

Provide some descriptions.

Added a PR description.

@google google deleted a comment from s8627 Nov 1, 2022
Copy link
Collaborator

@mdmathias mdmathias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note to leave a clarifying comment. LGTM otherwise.

Add comment explaining fork exclusion.
@petea petea changed the title Tweak workflow triggers Improve our workflows Nov 2, 2022
@petea petea merged commit 6ab0211 into main Nov 2, 2022
@petea petea deleted the petea-workflows branch November 2, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants