Fix macro in GIDGoogleUser.m #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@Alex-4-Git is this intended to be a draft PR still? Also, the integration tests failed. |
petea
approved these changes
Nov 28, 2022
Contributor
petea
left a comment
petea
left a comment
There was a problem hiding this comment.
This appears to be the root cause.
@mdmathias note the randomness of the macOS build failures here, sometimes on the macOS-11 runner, sometimes macOS-12, sometimes both. It's as though xcodebuild is randomly choosing when to build for Mac Catalyst in this case.
https://github.com/google/GoogleSignIn-iOS/actions/workflows/builds.yml
mdmathias
approved these changes
Nov 28, 2022
petea
reviewed
Nov 29, 2022
| #elif TARGET_OS_OSX | ||
| presentingWindow:(NSWindow *)presentingWindow | ||
| #endif // TARGET_OS_IOS && !TARGET_OS_MACCATALYST | ||
| #endif // TARGET_OS_IOS || TARGET_OS_MACCATALYST |
Contributor
There was a problem hiding this comment.
@Alex-4-Git note that you missed an instance of the same platform check mistake below and the build action is now failing for that reason:
https://github.com/google/GoogleSignIn-iOS/actions/runs/3572147376/jobs/6004706482
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the the build integration test failure on GSI-iOS.
https://github.com/google/GoogleSignIn-iOS/actions/runs/3502685894/jobs/5867240619#step:4:1011