Skip to content

Add GIDProfileDataFetcher #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 11, 2023
Merged

Add GIDProfileDataFetcher #278

merged 11 commits into from
Jan 11, 2023

Conversation

@Alex-4-Git
Copy link
Contributor

@Alex-4-Git Alex-4-Git commented Dec 29, 2022

GIDProfileDataFetcher fetches the user info. It either extracts an ID token out of the OIDAuthState object or fetches user profile data through GIDHTTPFetcher.

Details in this PR:

  1. Add GIDProfileDataFetcher API, implementation and unit test.
  2. Convert the creation of GIDProfileData in GIDSignIn.m into an initializer of GIDProfileData.

Next step:
Create a fake for GIDProfileDataFetcher and use it in GIDSignInTest.m to replace mocks.

@Alex-4-Git Alex-4-Git force-pushed the pin-GIDProfileDataFetcher-new branch from c1ecc6a to 4c2172b Compare December 30, 2022 00:01
@Alex-4-Git Alex-4-Git requested a review from ch40w31 December 30, 2022 00:02
@Alex-4-Git Alex-4-Git marked this pull request as ready for review December 30, 2022 00:02
ch40w31
ch40w31 requested changes Dec 30, 2022
View reviewed changes
@Alex-4-Git Alex-4-Git force-pushed the pin-GIDProfileDataFetcher-new branch from 491939b to 242007e Compare January 2, 2023 19:53
@Alex-4-Git Alex-4-Git requested a review from ch40w31 January 2, 2023 19:55
@Alex-4-Git Alex-4-Git force-pushed the pin-GIDProfileDataFetcher-new branch from 242007e to e2bd4ff Compare January 3, 2023 18:10
@google google deleted a comment from s8627 Jan 3, 2023
@Alex-4-Git Alex-4-Git force-pushed the pin-GIDProfileDataFetcher-new branch from e2bd4ff to 4d13ed2 Compare January 3, 2023 18:20
petea
petea suggested changes Jan 3, 2023
View reviewed changes
@Alex-4-Git Alex-4-Git requested a review from petea January 3, 2023 23:04
ch40w31
ch40w31 requested changes Jan 4, 2023
View reviewed changes
@Alex-4-Git Alex-4-Git requested a review from ch40w31 January 4, 2023 18:35
petea
petea suggested changes Jan 5, 2023
View reviewed changes
@Alex-4-Git Alex-4-Git requested a review from petea January 5, 2023 02:23
petea
petea reviewed Jan 7, 2023
View reviewed changes
@Alex-4-Git
Move the new GIDProfileData initializer to GIDProfileDataFetcher
3c9e883 
The profile data items in the ID token and UserInfo endpoint response share keys so we decide to put them together in GIDProfileDataFetcher.
@Alex-4-Git Alex-4-Git requested a review from petea January 9, 2023 21:21
petea
petea suggested changes Jan 10, 2023
View reviewed changes
@Alex-4-Git Alex-4-Git requested a review from petea January 10, 2023 18:51
petea
petea suggested changes Jan 10, 2023
View reviewed changes
@Alex-4-Git Alex-4-Git requested a review from petea January 10, 2023 22:34
@Alex-4-Git Alex-4-Git merged commit ba223db into refactorGSI Jan 11, 2023
@Alex-4-Git Alex-4-Git deleted the pin-GIDProfileDataFetcher-new branch January 11, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ch40w31 ch40w31 Awaiting requested review from ch40w31

1 more reviewer

@petea petea petea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alex-4-Git @petea @ch40w31