Add GIDAuthorizationFlowProcessor #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-4-Git
force-pushed
the
pin-GIDAuthorizationFlowProcessor
branch
from
06a0eae to
0e80a9d
Compare
Alex-4-Git
force-pushed
the
pin-GIDAuthorizationFlowProcessor
branch
from
7647091 to
ec80960
Compare
mdmathias
requested changes
Jan 7, 2023
GoogleSignIn/Sources/GIDAuthorizationFlowProcessor/API/GIDAuthorizationFlowProcessor.h
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationFlowProcessor/API/GIDAuthorizationFlowProcessor.h
Show resolved
Hide resolved
...SignIn/Sources/GIDAuthorizationFlowProcessor/Implementations/GIDAuthorizationFlowProcessor.h
Show resolved
Hide resolved
...SignIn/Sources/GIDAuthorizationFlowProcessor/Implementations/GIDAuthorizationFlowProcessor.m
Outdated
Show resolved
Hide resolved
...SignIn/Sources/GIDAuthorizationFlowProcessor/Implementations/GIDAuthorizationFlowProcessor.m
Show resolved
Hide resolved
...SignIn/Sources/GIDAuthorizationFlowProcessor/Implementations/GIDAuthorizationFlowProcessor.m
Outdated
Show resolved
Hide resolved
mdmathias
requested changes
Jan 10, 2023
GoogleSignIn/Sources/GIDAuthorizationFlowProcessor/API/GIDAuthorizationFlowProcessor.h
Show resolved
Hide resolved
petea
suggested changes
Jan 10, 2023
GoogleSignIn/Sources/GIDAuthorizationFlowProcessor/API/GIDAuthorizationFlowProcessor.h
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationFlowProcessor/API/GIDAuthorizationFlowProcessor.h
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationFlowProcessor/API/GIDAuthorizationFlowProcessor.h
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationFlowProcessor/API/GIDAuthorizationFlowProcessor.h
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationFlowProcessor/API/GIDAuthorizationFlowProcessor.h
Outdated
Show resolved
Hide resolved
mdmathias
approved these changes
Jan 11, 2023
petea
suggested changes
Jan 11, 2023
.swiftpm/xcode/xcshareddata/xcschemes/GoogleSignIn-UnitTests.xcscheme
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationFlowProcessor/API/GIDAuthorizationFlowProcessor.h
Show resolved
Hide resolved
...SignIn/Sources/GIDAuthorizationFlowProcessor/Implementations/GIDAuthorizationFlowProcessor.h
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GIDAuthorizationFlowProcessor can start, resume and cancel the authorization flow. This class is extracted out of
GIDSignIn.mso GIDSignIn implementation can be simplified and easier to understand and test.This PR adds protocol, implementation and unit tests. The fake will be added in the next PR.