Add GIDAuthorizationUtil class. #288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
GIDAuthorizationUtilcontains two utility methods. It helps us test these methods easily and reduce theGIDSIgnInTestcomplexity vastly.In
GIDSignInTestthere are some tests using anOIDAuthorizationRequest. In productionGIDSignInsends anOIDAuthorizationRequestto AppAuth to start the authorization flow. InGIDSignInTestwe saved the request and use this to verify the parameters and scopes before sending it to an AppAuth mock. By extracting these method we can verify the request and scopes directly instead of verifying them along with the whole sign-in flow.