Skip to content

Conversation

@Alex-4-Git
Copy link
Contributor

@Alex-4-Git Alex-4-Git commented Jan 13, 2023

The class GIDAuthorizationUtil contains two utility methods. It helps us test these methods easily and reduce the GIDSIgnInTest complexity vastly.

In GIDSignInTest there are some tests using an OIDAuthorizationRequest. In production GIDSignIn sends an OIDAuthorizationRequest to AppAuth to start the authorization flow. In GIDSignInTest we saved the request and use this to verify the parameters and scopes before sending it to an AppAuth mock. By extracting these method we can verify the request and scopes directly instead of verifying them along with the whole sign-in flow.

@Alex-4-Git Alex-4-Git marked this pull request as ready for review January 13, 2023 22:21
@Alex-4-Git Alex-4-Git requested a review from ch40w31 January 13, 2023 22:21
@Alex-4-Git Alex-4-Git requested a review from ch40w31 January 14, 2023 05:00
@Alex-4-Git Alex-4-Git force-pushed the pin-GIDAuthorizationFlowProcessorUtil branch from 60e2287 to 62be44a Compare January 17, 2023 18:40
@Alex-4-Git Alex-4-Git merged commit 2138a3a into refactorGSI Jan 17, 2023
@Alex-4-Git Alex-4-Git deleted the pin-GIDAuthorizationFlowProcessorUtil branch January 17, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants