-
Notifications
You must be signed in to change notification settings - Fork 690
fix: update links to the sample code and other minor fixes #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix: update links to the sample code and other minor fixes
joefernandez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with fixes.
docs/streaming/dev-guide/part1.md
Outdated
|
|
||
| These components are created once when your application starts and shared across all streaming sessions. They define your agent's capabilities, manage conversation history, and orchestrate the streaming execution. | ||
|
|
||
| !!! info "Python Version Requirement" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't include this note, here. There is a notice on the front page.
Adding this here is too much information and it will be out of date in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
docs/streaming/dev-guide/part3.md
Outdated
|
|
||
| !!! note "Async Context Required" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set your editor to trim white space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
docs/streaming/dev-guide/part4.md
Outdated
| Note over ADK,Gemini: Turn Detection: finish_reason | ||
| ``` | ||
|
|
||
| !!! info "Progressive SSE Streaming (New in v1.19.0)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of issues:
- don't make this a note. Just add a heading and discuss how to use the feature
- Remove "New" notice. Generally, don't put "New" in docs; this dates the docs and you aren't going to remember to remove this in 2 months when this feature NOT new.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, edited my style guide not to include any specific version-dependent texts.
| ``` | ||
|
|
||
| !!! info "Progressive SSE Streaming (New in v1.19.0)" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To flag that this feature is v1.19 and later (and experimental) add this tag under your new heading:
<div class="language-support-tag">
<span class="lst-supported">Supported in ADK</span><span class="lst-python">Python v1.19.0</span><span class="lst-preview">Experimental</span>
</div>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joefernandez so far I haven't use this tag as I don't know how to. For this guide I changed it to version independent and am trying to be updated to the latest version as soon as possible. What's your recommendation on using this tag on this guide.
docs/streaming/dev-guide/part4.md
Outdated
|
|
||
| !!! info "Progressive SSE Streaming (New in v1.19.0)" | ||
|
|
||
| ADK v1.19.0 introduced **progressive SSE streaming**, an experimental feature that enhances how SSE mode delivers streaming responses. When enabled, this feature improves response aggregation by: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ADK v1.19.0 introduced progressive SSE streaming, an experimental feature that
change to: (remove version and experimental language; let the tags communicate that)
Progressive SSE streaming is a feature that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
fix: deleting the old custom streaming guides.
- Remove version-specific references (v1.18.0, v1.19.0) for evergreen docs - Update source permalinks from blob/main to v1.20.0 commit hashes - Fix dead link: streamed-conversations → live-api (404 fix) - Convert info admonitions to regular sections per style guide
fix: update links to the sample code and other minor fixes