Merged
Conversation
d205af6 to
73cf7c8
Compare
ScottMansfield
requested changes
Apr 14, 2026
a60ffc5 to
02528e1
Compare
73cf7c8 to
ba55dfd
Compare
6cf8b8b to
c3804da
Compare
f26e181 to
1727a5d
Compare
ScottMansfield
approved these changes
Apr 16, 2026
d05ea55 to
3c61e11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
Problem:
The ADK needs a way to load and validate "Skills" defined as Markdown files with YAML frontmatter from local directories. This is part of the larger Skills feature.
Solution:
Implemented a skills file loader in
core/src/skills/loader.ts. This module provides functionality to:SKILL.mdfiles, separating YAML frontmatter from the Markdown body.Added comprehensive unit tests in
core/test/skills/loader_test.tsto verify these behaviors.Testing Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
N/A for this component-level feature. E2E tests will be covered in future PRs integrating skills with the runner.
Checklist