Skip to content

feat: skills: loader (part 3)#256

Merged
kalenkevich merged 14 commits intomainfrom
feat/skills_part3
Apr 16, 2026
Merged

feat: skills: loader (part 3)#256
kalenkevich merged 14 commits intomainfrom
feat/skills_part3

Conversation

@kalenkevich
Copy link
Copy Markdown
Collaborator

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

2. Or, if no issue exists, describe the change:

Problem:
The ADK needs a way to load and validate "Skills" defined as Markdown files with YAML frontmatter from local directories. This is part of the larger Skills feature.

Solution:
Implemented a skills file loader in core/src/skills/loader.ts. This module provides functionality to:

  • Parse SKILL.md files, separating YAML frontmatter from the Markdown body.
  • Load a full skill directory, including associated resources (assets, references, scripts) from subdirectories.
  • Validate a skill directory structure and frontmatter without fully loading all assets.
  • List all valid skills within a base directory.

Added comprehensive unit tests in core/test/skills/loader_test.ts to verify these behaviors.

Testing Plan

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Manual End-to-End (E2E) Tests:
N/A for this component-level feature. E2E tests will be covered in future PRs integrating skills with the runner.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end

@kalenkevich kalenkevich self-assigned this Apr 10, 2026
@kalenkevich kalenkevich changed the title feat: skills loader feat: skills loader (part 3) Apr 10, 2026
@kalenkevich kalenkevich changed the title feat: skills loader (part 3) feat: skills: loader (part 3) Apr 10, 2026
Comment thread core/src/skills/loader.ts Outdated
Comment thread core/src/skills/loader.ts Outdated
Comment thread core/src/skills/loader.ts Outdated
Comment thread core/src/skills/loader.ts
Comment thread core/src/skills/loader.ts Outdated
Comment thread core/src/skills/loader.ts Outdated
Comment thread core/src/skills/loader.ts Outdated
Base automatically changed from feat/skills_part2 to main April 15, 2026 21:06
@kalenkevich kalenkevich force-pushed the feat/skills_part3 branch 2 times, most recently from 6cf8b8b to c3804da Compare April 15, 2026 21:13
Comment thread core/src/skills/loader.ts
@kalenkevich kalenkevich merged commit a4d2858 into main Apr 16, 2026
7 checks passed
@kalenkevich kalenkevich deleted the feat/skills_part3 branch April 16, 2026 01:10
@kalenkevich kalenkevich mentioned this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants