Skip to content

Conversation

@designcomputer
Copy link
Contributor

Summary

Updated the Toolbox Agent documentation to address a critical missing dependency that prevents the agent from running successfully.

Changes Made

  • Added missing dependency: Documented that toolbox-core must be installed via pip install toolbox-core
  • Improved documentation structure: Added clear section numbering and better organization
  • Enhanced readability: Fixed grammar, capitalization, and formatting throughout
  • Added Prerequisites section: Set clear expectations before installation begins
  • Clarified optional steps: Made it clearer when database creation can be skipped

Problem Solved

The original documentation was missing a crucial step - installing the toolbox-core package. Without this dependency, users encounter an ImportError: No module named 'toolbox-core' when trying to use the ToolboxToolset class in ADK. This fix ensures users can successfully set up and run the agent without encountering import errors.

Testing

  • Verified the installation steps work correctly with the added dependency
  • Confirmed the agent runs successfully after following the updated documentation

@hangfei
Copy link
Collaborator

hangfei commented Jul 18, 2025

Please fix the conventionalcommits and re-open.

@hangfei hangfei closed this Jul 18, 2025
@seanzhou1023 seanzhou1023 changed the title Fix missing toolbox-core dependency in Toolbox Agent documentation docs: Fix missing toolbox-core dependency and improve installation guide Jul 21, 2025
@seanzhou1023 seanzhou1023 reopened this Jul 21, 2025
@kurtisvg
Copy link

Appreciate the contribution @designcomputer !

@seanzhou1023 seanzhou1023 added the ready to pull [Status] This PR is ready to be importing back to Google label Jul 21, 2025
copybara-service bot pushed a commit that referenced this pull request Jul 21, 2025
Merge #1195

## Summary
Updated the Toolbox Agent documentation to address a critical missing dependency that prevents the agent from running successfully.

## Changes Made
- **Added missing dependency**: Documented that `toolbox-core` must be installed via `pip install toolbox-core`
- **Improved documentation structure**: Added clear section numbering and better organization
- **Enhanced readability**: Fixed grammar, capitalization, and formatting throughout
- **Added Prerequisites section**: Set clear expectations before installation begins
- **Clarified optional steps**: Made it clearer when database creation can be skipped

## Problem Solved
The original documentation was missing a crucial step - installing the `toolbox-core` package. Without this dependency, users encounter an `ImportError: No module named 'toolbox-core'` when trying to use the `ToolboxToolset` class in ADK. This fix ensures users can successfully set up and run the agent without encountering import errors.

## Testing
- Verified the installation steps work correctly with the added dependency
- Confirmed the agent runs successfully after following the updated documentation

COPYBARA_INTEGRATE_REVIEW=#1195 from designcomputer:patch-1 b90c71f
PiperOrigin-RevId: 785487495
pandasanjay pushed a commit to pandasanjay/adk-python that referenced this pull request Jul 28, 2025
Merge google#1195

## Summary
Updated the Toolbox Agent documentation to address a critical missing dependency that prevents the agent from running successfully.

## Changes Made
- **Added missing dependency**: Documented that `toolbox-core` must be installed via `pip install toolbox-core`
- **Improved documentation structure**: Added clear section numbering and better organization
- **Enhanced readability**: Fixed grammar, capitalization, and formatting throughout
- **Added Prerequisites section**: Set clear expectations before installation begins
- **Clarified optional steps**: Made it clearer when database creation can be skipped

## Problem Solved
The original documentation was missing a crucial step - installing the `toolbox-core` package. Without this dependency, users encounter an `ImportError: No module named 'toolbox-core'` when trying to use the `ToolboxToolset` class in ADK. This fix ensures users can successfully set up and run the agent without encountering import errors.

## Testing
- Verified the installation steps work correctly with the added dependency
- Confirmed the agent runs successfully after following the updated documentation

COPYBARA_INTEGRATE_REVIEW=google#1195 from designcomputer:patch-1 b90c71f
PiperOrigin-RevId: 785487495
knaou pushed a commit to knaou/adk-python that referenced this pull request Aug 16, 2025
Merge google#1195

## Summary
Updated the Toolbox Agent documentation to address a critical missing dependency that prevents the agent from running successfully.

## Changes Made
- **Added missing dependency**: Documented that `toolbox-core` must be installed via `pip install toolbox-core`
- **Improved documentation structure**: Added clear section numbering and better organization
- **Enhanced readability**: Fixed grammar, capitalization, and formatting throughout
- **Added Prerequisites section**: Set clear expectations before installation begins
- **Clarified optional steps**: Made it clearer when database creation can be skipped

## Problem Solved
The original documentation was missing a crucial step - installing the `toolbox-core` package. Without this dependency, users encounter an `ImportError: No module named 'toolbox-core'` when trying to use the `ToolboxToolset` class in ADK. This fix ensures users can successfully set up and run the agent without encountering import errors.

## Testing
- Verified the installation steps work correctly with the added dependency
- Confirmed the agent runs successfully after following the updated documentation

COPYBARA_INTEGRATE_REVIEW=google#1195 from designcomputer:patch-1 b90c71f
PiperOrigin-RevId: 785487495
@ryanaiagent ryanaiagent self-assigned this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull [Status] This PR is ready to be importing back to Google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants