Skip to content

Conversation

@soundTricker
Copy link
Contributor

Fixes #80

Add configure_sa_auth method to GoogleApiTool and GoogleApiToolSet to configure auth with Service Account and Application Default Credentials.

@soundTricker soundTricker force-pushed the feature/80-sa-auth-for-google-tool branch from ba473a0 to 0c45641 Compare April 30, 2025 05:15
@soundTricker
Copy link
Contributor Author

Note: added some unittest.

@hangfei
Copy link
Collaborator

hangfei commented May 30, 2025

@seanzhou1023 Could you help review this change?

@hangfei
Copy link
Collaborator

hangfei commented May 30, 2025

@soundTricker could you resolve the conflicts?

@hangfei hangfei requested a review from seanzhou1023 May 30, 2025 19:26
@seanzhou1023
Copy link
Collaborator

@soundTricker Did you test it in GCP environment ?

@soundTricker
Copy link
Contributor Author

@seanzhou1023 in my memory yes, but i retry when fixing the conflict.

@soundTricker soundTricker force-pushed the feature/80-sa-auth-for-google-tool branch from 0c45641 to 22e79cc Compare June 1, 2025 09:42
@soundTricker
Copy link
Contributor Author

@seanzhou1023 I've fixed the conflict and finished the test on cloud run.

@seanzhou1023 seanzhou1023 added ready to pull [Status] This PR is ready to be importing back to Google and removed ready to pull [Status] This PR is ready to be importing back to Google labels Jul 11, 2025
@seanzhou1023 seanzhou1023 added ready to pull [Status] This PR is ready to be importing back to Google and removed ready to pull [Status] This PR is ready to be importing back to Google labels Jul 11, 2025
@seanzhou1023 seanzhou1023 added the ready to pull [Status] This PR is ready to be importing back to Google label Jul 11, 2025
@seanzhou1023 seanzhou1023 force-pushed the feature/80-sa-auth-for-google-tool branch from d91d62a to aed6345 Compare July 11, 2025 04:11
@seanzhou1023 seanzhou1023 changed the title feat: add configure service account auth for google_api_tool_set (#80) feat: Add configure service account auth for google_api_tool_set Jul 11, 2025
@seanzhou1023 seanzhou1023 force-pushed the feature/80-sa-auth-for-google-tool branch from aed6345 to b1952a8 Compare July 11, 2025 04:23
@seanzhou1023 seanzhou1023 force-pushed the feature/80-sa-auth-for-google-tool branch from b1952a8 to 4c5ef1e Compare July 11, 2025 04:24
@copybara-service copybara-service bot merged commit 4ba0f0a into google:main Jul 11, 2025
12 checks passed
@soundTricker soundTricker deleted the feature/80-sa-auth-for-google-tool branch July 11, 2025 12:34
pandasanjay pushed a commit to pandasanjay/adk-python that referenced this pull request Jul 28, 2025
…r-google-tool

PiperOrigin-RevId: 781815460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull [Status] This PR is ready to be importing back to Google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance: Support Service Account Application Default Credentials on google.adk.tools.google_api_tool.google_api_tool_sets module

4 participants