Skip to content

Fix: Map finish_reason for LiteLLM streaming responses #3677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −0
Open

Fix: Map finish_reason for LiteLLM streaming responses #3677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/google/adk/models/lite_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1348,6 +1348,20 @@ async def generate_content_async(
else None,
)
)
# FIX: Map finish_reason to FinishReason enum for streaming responses.
# Previously, streaming responses did not set finish_reason on aggregated
# LlmResponse objects, causing the ADK agent runner to not properly recognize
# completion states. This mirrors the logic from non-streaming path (lines 776-784)
# to ensure consistent behavior across both streaming and non-streaming modes.
# Without this, Claude and other models via LiteLLM would hit stop conditions
# that the agent couldn't properly handle.
if isinstance(finish_reason, types.FinishReason):
aggregated_llm_response_with_tool_call.finish_reason = finish_reason
else:
finish_reason_str = str(finish_reason).lower()
aggregated_llm_response_with_tool_call.finish_reason = _FINISH_REASON_MAPPING.get(
finish_reason_str, types.FinishReason.OTHER
)
text = ""
reasoning_parts = []
function_calls.clear()
Expand All @@ -1362,6 +1376,20 @@ async def generate_content_async(
if reasoning_parts
else None,
)
# FIX: Map finish_reason to FinishReason enum for streaming text-only responses.
# Previously, streaming responses did not set finish_reason on aggregated
# LlmResponse objects, causing the ADK agent runner to not properly recognize
# completion states. This mirrors the logic from non-streaming path (lines 776-784)
# to ensure consistent behavior across both streaming and non-streaming modes.
# Without this, Claude and other models via LiteLLM would hit stop conditions
# that the agent couldn't properly handle.
if isinstance(finish_reason, types.FinishReason):
aggregated_llm_response.finish_reason = finish_reason
else:
finish_reason_str = str(finish_reason).lower()
aggregated_llm_response.finish_reason = _FINISH_REASON_MAPPING.get(
finish_reason_str, types.FinishReason.OTHER
)
text = ""
reasoning_parts = []

Expand Down