Skip to content

feat: Update check-file-contents.yml to check for non-mTLS hardcoded … #5774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agrawalradhika-cell wants to merge 14 commits into from
+34 −0
Closed

feat: Update check-file-contents.yml to check for non-mTLS hardcoded … #5774

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d9d7389
feat: Update check-file-contents.yml to check for non-mTLS hardcoded …
agrawalradhika-cell May 20, 2026
cd623c6
Merge branch 'google:main' into update-linter-for-hardcoded
agrawalradhika-cell May 20, 2026
03b9994
chore: test linter by Update agent.py
agrawalradhika-cell May 21, 2026
0c4f8a1
fix: fix check to make sure mTLS endpoints are ignored
agrawalradhika-cell May 21, 2026
5887a5c
fix: remove the testing enfpoint
agrawalradhika-cell May 21, 2026
d1cc7ec
Merge branch 'main' into update-linter-for-hardcoded
DeanChensj May 21, 2026
f51bc20
fix: fixing line omit lint in agent.py
agrawalradhika-cell May 21, 2026
52ce0b7
chore: Improve logic to Update check-file-contents.yml
agrawalradhika-cell May 21, 2026
5bd4e1f
chore: improve the instruction for user by Update check-file-contents…
agrawalradhika-cell May 21, 2026
0db069d
Merge branch 'main' into update-linter-for-hardcoded
DeanChensj May 21, 2026
ccbe53e
Merge branch 'main' into update-linter-for-hardcoded
DeanChensj May 21, 2026
03555f5
Merge branch 'main' into update-linter-for-hardcoded
sasha-gitg May 22, 2026
c170c23
Merge branch 'main' into update-linter-for-hardcoded
DeanChensj May 22, 2026
29fcd80
Merge branch 'main' into update-linter-for-hardcoded
sasha-gitg May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/check-file-contents.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,3 +100,37 @@ jobs:
else
echo "✅ No relevant Python files found."
fi

- name: Check for hardcoded googleapis.com endpoints
run: |
git fetch origin ${GITHUB_BASE_REF}
CHANGED_FILES=$(git diff --diff-filter=ACMR --name-only origin/${GITHUB_BASE_REF}...HEAD | grep -E '\.py$' || true)
if [ -n "$CHANGED_FILES" ]; then
echo "Checking for hardcoded endpoints in: $CHANGED_FILES"

# 1. Identify files containing any googleapis.com URL.
set +e
Comment thread
agrawalradhika-cell marked this conversation as resolved.
FILES_WITH_ENDPOINTS=$(grep -lE 'https?://[a-zA-Z0-9.-]+\.googleapis\.com' $CHANGED_FILES)

# 2. From those, identify files that are MISSING the required mTLS version.
if [ -n "$FILES_WITH_ENDPOINTS" ]; then
FILES_MISSING_MTLS=$(grep -L '.mtls.googleapis.com' $FILES_WITH_ENDPOINTS)
fi
set -e

if [ -n "$FILES_MISSING_MTLS" ]; then
echo "❌ Found hardcoded googleapis.com endpoints without mTLS support."
echo "The following files must define both standard and mTLS (.mtls.googleapis.com) endpoints"
echo "to support dynamic endpoint selection as required by security policy:"
echo "$FILES_MISSING_MTLS"
echo ""
echo "To fix this, please follow these steps:"
echo "1. Initialize an AuthorizedSession with your credentials."
echo "2. Use 'mtls.has_default_client_cert_source() from google-auth' to check for available client certificates."
echo "3. If certificates are present, use 'session.configure_mtls_channel()'."
echo "4. Dynamically select the '.mtls.' variant of the endpoint when mTLS is active."
exit 1
else
echo "✅ All hardcoded endpoints have corresponding mTLS definitions or no endpoints found."
fi
fi
Loading