-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fixes #144 CMake fails without Git #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
9cef14f to
775ef51
Compare
|
I signed it! |
|
please make sure the author email on the commits matches the expectations from the corporate CLA. |
|
The author email is an address associated with our googlegroup which I believe should be sufficient? |
|
possibly. we shall wait and see and i'll poke the bear on this side if nothing happens. |
|
The CLA was just signed and filed by Google |
|
I would also like to remove the CMake message that prints GIT_VERSION? |
|
@ulvgard sounds good in the case that git isn't available. |
|
@googlebot he signed it. check again. |
|
@ulvgard whenever you can, please reply "I signed it!" so googlebot updates. |
|
I signed it! |
|
the bot still thinks you didn't. maybe the commit author doesn't match expectations? |
|
Yep, somehow the email was not related to the googlegroup. Even though I remember registering it. Anyway... Thanks Dominic |
|
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed this version bump, but it was released in 2013. Commenting for posterity that it was noticed and approved.
Fixes #144 CMake fails without Git
With this patch GetGitVersion.cmake checks for the existance of Git before attempting to get Benchmark version from the logs. If Git is not found, the version is set to v0.0.0 as was the default behaviour of the script.