Skip to content

Conversation

@ulvgard
Copy link
Contributor

@ulvgard ulvgard commented Oct 2, 2015

With this patch GetGitVersion.cmake checks for the existance of Git before attempting to get Benchmark version from the logs. If Git is not found, the version is set to v0.0.0 as was the default behaviour of the script.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ulvgard
Copy link
Contributor Author

ulvgard commented Oct 7, 2015

I signed it!
(Corporation DiracResearch)

@dmah42
Copy link
Member

dmah42 commented Oct 7, 2015

please make sure the author email on the commits matches the expectations from the corporate CLA.

@ulvgard
Copy link
Contributor Author

ulvgard commented Oct 7, 2015

The author email is an address associated with our googlegroup which I believe should be sufficient?
Maybee, the CLA must be approved by Google first.

@dmah42
Copy link
Member

dmah42 commented Oct 7, 2015

possibly. we shall wait and see and i'll poke the bear on this side if nothing happens.

@ulvgard
Copy link
Contributor Author

ulvgard commented Oct 8, 2015

The CLA was just signed and filed by Google

@ulvgard
Copy link
Contributor Author

ulvgard commented Oct 8, 2015

I would also like to remove the CMake message that prints GIT_VERSION?

@dmah42
Copy link
Member

dmah42 commented Oct 8, 2015

@ulvgard sounds good in the case that git isn't available.

@dmah42
Copy link
Member

dmah42 commented Oct 8, 2015

@googlebot he signed it. check again.

@dmah42
Copy link
Member

dmah42 commented Oct 8, 2015

@ulvgard whenever you can, please reply "I signed it!" so googlebot updates.

@ulvgard
Copy link
Contributor Author

ulvgard commented Oct 9, 2015

I signed it!
(Corporation DiracResearch)

@dmah42
Copy link
Member

dmah42 commented Oct 12, 2015

the bot still thinks you didn't. maybe the commit author doesn't match expectations?

@ulvgard
Copy link
Contributor Author

ulvgard commented Oct 12, 2015

Yep, somehow the email was not related to the googlegroup. Even though I remember registering it. Anyway... Thanks Dominic

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed this version bump, but it was released in 2013. Commenting for posterity that it was noticed and approved.

dmah42 pushed a commit that referenced this pull request Oct 12, 2015
@dmah42 dmah42 merged commit 9b84ead into google:master Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants