Skip to content

Adding PHP Generator Support#98

Closed
daarond wants to merge 11 commits intoRaspberryPiFoundation:masterfrom
daarond:master
Closed

Adding PHP Generator Support#98
daarond wants to merge 11 commits intoRaspberryPiFoundation:masterfrom
daarond:master

Conversation

@daarond
Copy link
Contributor

@daarond daarond commented May 12, 2015

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New files should be dated with the current year 2015. [Change here and all other new files.]

You could also change Google Inc to be yourself or your company, but that would mean our lawyers would need to contact you with stuff to sign. Thanks for leaving this as Google, with yourself as the author below. [No change needed.]

@NeilFraser
Copy link
Contributor

Can you also edit tests/generators to add a PHP test generator and verify that they all pass?
https://developers.google.com/blockly/hacking/unit-testing
Thanks.

@NeilFraser
Copy link
Contributor

Hi daarond,
Do you want to reply to this guy:
https://groups.google.com/forum/#!topic/blockly/OdiWXX7CjBQ
It is your code, and he's willing to pay. :) Have fun!

@daarond
Copy link
Contributor Author

daarond commented May 13, 2015

Sure, I'll reply to him. I have a bit more debugging to do, then I will
have something for you to look at.
On May 13, 2015 2:16 AM, "Neil Fraser" notifications@github.com wrote:

Hi daarond,
Do you want to reply to this guy:
https://groups.google.com/forum/#!topic/blockly/OdiWXX7CjBQ
It is your code, and he's willing to pay. :) Have fun!


Reply to this email directly or view it on GitHub
#98 (comment).

@daarond
Copy link
Contributor Author

daarond commented May 13, 2015

All tests pass and I believe I have fixed the outstanding items, Neil.
Please let me know if there are any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants