Skip to content

Release v0.25.0 #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2017
Merged

Release v0.25.0 #1609

merged 1 commit into from
Mar 9, 2017

Conversation

@dashpole
Copy link
Collaborator

@dashpole dashpole commented Mar 9, 2017 •
edited by timstclair
Loading

@dashpole
Copy link
Collaborator Author

dashpole commented Mar 9, 2017

@k8s-bot test this

timstclair
timstclair reviewed Mar 9, 2017
View reviewed changes
CHANGELOG.md Outdated
- disable thin_ls due to excessive iops
- ignore .mount cgroups, fixing dissappearing stats
- Fix wc goroutine leak
- use sha256 for cAdvisor releases
Copy link
Contributor

@timstclair timstclair Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can drop this

Copy link
Collaborator Author

@dashpole dashpole Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

CHANGELOG.md Outdated
# Changelog

### 0.25.0 (2017-03-09)
- disable thin_ls due to excessive iops
Copy link
Contributor

@timstclair timstclair Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consistent capitalization. start each line with uppercase

Copy link
Collaborator Author

@dashpole dashpole Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

CHANGELOG.md Outdated
- Fix wc goroutine leak
- use sha256 for cAdvisor releases
- update aws-sdk-go dependency to 1.6.10
- cAdvisor tested with latest 1.7 go release
Copy link
Contributor

@timstclair timstclair Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reword this to "Update to go 1.7 for releases"

Copy link
Collaborator Author

@dashpole dashpole Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

timstclair
timstclair approved these changes Mar 9, 2017
View reviewed changes
Copy link
Contributor

@timstclair timstclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timstclair timstclair merged commit 17543be into google:master Mar 9, 2017
@dashpole dashpole deleted the 1_6_release branch March 9, 2017 23:02
@dashpole dashpole mentioned this pull request Mar 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@timstclair timstclair timstclair approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@timstclair timstclair

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dashpole @timstclair