Skip to content

Conversation

@vmarmol
Copy link
Contributor

@vmarmol vmarmol commented Nov 17, 2014

No description provided.

@vmarmol
Copy link
Contributor Author

vmarmol commented Nov 17, 2014

Ping @vishh @rjnagal

@vmarmol
Copy link
Contributor Author

vmarmol commented Nov 17, 2014

Wait for the merge :) I have a couple of fixes.

CHANGELOG.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention ContainerStats API update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What update? The flattening? Since that doesn't affect the wire format, should we mention it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mention it.

On Mon, Nov 17, 2014 at 9:54 AM, Victor Marmol notifications@github.com
wrote:

In CHANGELOG.md:

@@ -1,5 +1,12 @@

Changelog

+## 0.6.0 (2014-11-17)
+- Adding /docker UI endpoint for Docker containers.
+- Fixes around handling Docker containers.
+- Performance enhancements.
+- Embed all external dependencies.
+- Misc bugfixes and cleanups.

What update? The flattening? Since that doesn't affect the wire format,
should we mention it?


Reply to this email directly or view it on GitHub
https://github.com/google/cadvisor/pull/310/files#r20451543.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@vmarmol
Copy link
Contributor Author

vmarmol commented Nov 17, 2014

This is now ready for merging :)

@vishh
Copy link
Contributor

vishh commented Nov 17, 2014

LGTM

vmarmol added a commit that referenced this pull request Nov 17, 2014
@vmarmol vmarmol merged commit 1e98602 into google:master Nov 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants