Add image name to container spec & prometheus metrics #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
LGTM Thanks @jimmidyson We already expose labels. The only remaining discussion is around env variables, which I am still not convinced is safe to do. |
rjnagal
added a commit
that referenced
this pull request
Aug 28, 2015
Add image name to container spec & prometheus metrics
|
Thanks! Agree on env vars - dangerous considering they're used for generated passwords, secret data, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #848
As discussed in #780 (comment), this just exports the image name as this has most immediate value. We can discuss docker labels separately perhaps?