Skip to content

No public description #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

No public description #1650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions common/values/custom_list_value_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,11 @@ class CustomListValueInterfaceTest final : public CustomListValueInterface {
json_array.add_values()->set_bool_value(true);
json_array.add_values()->set_number_value(1.0);
absl::Cord serialized;
if (!json_array.SerializePartialToCord(&serialized)) {
if (!json_array.SerializePartialToString(&serialized)) {
return absl::UnknownError(
"failed to serialize google.protobuf.ListValue");
}
if (!json->ParsePartialFromCord(serialized)) {
if (!json->ParsePartialFromString(serialized)) {
return absl::UnknownError("failed to parse google.protobuf.ListValue");
}
return absl::OkStatus();
Expand Down Expand Up @@ -191,11 +191,11 @@ class CustomListValueTest : public common_internal::ValueTest<> {
json_array.add_values()->set_bool_value(true);
json_array.add_values()->set_number_value(1.0);
absl::Cord serialized;
if (!json_array.SerializePartialToCord(&serialized)) {
if (!json_array.SerializePartialToString(&serialized)) {
return absl::UnknownError(
"failed to serialize google.protobuf.ListValue");
}
if (!json->ParsePartialFromCord(serialized)) {
if (!json->ParsePartialFromString(serialized)) {
return absl::UnknownError(
"failed to parse google.protobuf.ListValue");
}
Expand Down
8 changes: 4 additions & 4 deletions common/values/custom_struct_value_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ class CustomStructValueInterfaceTest final : public CustomStructValueInterface {
(*json_object.mutable_fields())["foo"].set_bool_value(true);
(*json_object.mutable_fields())["bar"].set_number_value(1.0);
absl::Cord serialized;
if (!json_object.SerializePartialToCord(&serialized)) {
if (!json_object.SerializePartialToString(&serialized)) {
return absl::UnknownError("failed to serialize google.protobuf.Struct");
}
if (!json->ParsePartialFromCord(serialized)) {
if (!json->ParsePartialFromString(serialized)) {
return absl::UnknownError("failed to parse google.protobuf.Struct");
}
return absl::OkStatus();
Expand Down Expand Up @@ -255,11 +255,11 @@ class CustomStructValueTest : public common_internal::ValueTest<> {
(*json_object.mutable_fields())["foo"].set_bool_value(true);
(*json_object.mutable_fields())["bar"].set_number_value(1.0);
absl::Cord serialized;
if (!json_object.SerializePartialToCord(&serialized)) {
if (!json_object.SerializePartialToString(&serialized)) {
return absl::UnknownError(
"failed to serialize google.protobuf.Struct");
}
if (!json->ParsePartialFromCord(serialized)) {
if (!json->ParsePartialFromString(serialized)) {
return absl::UnknownError("failed to parse google.protobuf.Struct");
}
return absl::OkStatus();
Expand Down
8 changes: 4 additions & 4 deletions common/values/parsed_json_list_value.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,11 @@ absl::Status ParsedJsonListValue::ConvertToJson(
} else {
// Equivalent descriptors but not identical. Must serialize and deserialize.
absl::Cord serialized;
if (!value_->SerializePartialToCord(&serialized)) {
if (!value_->SerializePartialToString(&serialized)) {
return absl::UnknownError(
absl::StrCat("failed to serialize message: ", value_->GetTypeName()));
}
if (!message->ParsePartialFromCord(serialized)) {
if (!message->ParsePartialFromString(serialized)) {
return absl::UnknownError(
absl::StrCat("failed to parsed message: ", message->GetTypeName()));
}
Expand Down Expand Up @@ -138,11 +138,11 @@ absl::Status ParsedJsonListValue::ConvertToJsonArray(
} else {
// Equivalent descriptors but not identical. Must serialize and deserialize.
absl::Cord serialized;
if (!value_->SerializePartialToCord(&serialized)) {
if (!value_->SerializePartialToString(&serialized)) {
return absl::UnknownError(
absl::StrCat("failed to serialize message: ", value_->GetTypeName()));
}
if (!json->ParsePartialFromCord(serialized)) {
if (!json->ParsePartialFromString(serialized)) {
return absl::UnknownError(
absl::StrCat("failed to parsed message: ", json->GetTypeName()));
}
Expand Down
8 changes: 4 additions & 4 deletions common/values/parsed_json_map_value.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,11 @@ absl::Status ParsedJsonMapValue::ConvertToJson(
} else {
// Equivalent descriptors but not identical. Must serialize and deserialize.
absl::Cord serialized;
if (!value_->SerializePartialToCord(&serialized)) {
if (!value_->SerializePartialToString(&serialized)) {
return absl::UnknownError(
absl::StrCat("failed to serialize message: ", value_->GetTypeName()));
}
if (!message->ParsePartialFromCord(serialized)) {
if (!message->ParsePartialFromString(serialized)) {
return absl::UnknownError(
absl::StrCat("failed to parsed message: ", message->GetTypeName()));
}
Expand Down Expand Up @@ -141,11 +141,11 @@ absl::Status ParsedJsonMapValue::ConvertToJsonObject(
} else {
// Equivalent descriptors but not identical. Must serialize and deserialize.
absl::Cord serialized;
if (!value_->SerializePartialToCord(&serialized)) {
if (!value_->SerializePartialToString(&serialized)) {
return absl::UnknownError(
absl::StrCat("failed to serialize message: ", value_->GetTypeName()));
}
if (!json->ParsePartialFromCord(serialized)) {
if (!json->ParsePartialFromString(serialized)) {
return absl::UnknownError(
absl::StrCat("failed to parsed message: ", json->GetTypeName()));
}
Expand Down
4 changes: 2 additions & 2 deletions common/values/struct_value_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,11 @@ absl::StatusOr<absl::optional<ErrorValue>> ProtoMessageCopyUsingSerialization(
google::protobuf::MessageLite* to, const google::protobuf::MessageLite* from) {
ABSL_DCHECK_EQ(to->GetTypeName(), from->GetTypeName());
absl::Cord serialized;
if (!from->SerializePartialToCord(&serialized)) {
if (!from->SerializePartialToString(&serialized)) {
return absl::UnknownError(
absl::StrCat("failed to serialize `", from->GetTypeName(), "`"));
}
if (!to->ParsePartialFromCord(serialized)) {
if (!to->ParsePartialFromString(serialized)) {
return absl::UnknownError(
absl::StrCat("failed to parse `", to->GetTypeName(), "`"));
}
Expand Down