Skip to content

Address a few compiler warnings for clang. #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Address a few compiler warnings for clang. #1652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions checker/standard_library.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,18 +103,6 @@ Type TypeBytesType() {
return *kInstance;
}

Type TypeDurationType() {
static absl::NoDestructor<Type> kInstance(
TypeType(BuiltinsArena(), DurationType()));
return *kInstance;
}

Type TypeTimestampType() {
static absl::NoDestructor<Type> kInstance(
TypeType(BuiltinsArena(), TimestampType()));
return *kInstance;
}

Type TypeDynType() {
static absl::NoDestructor<Type> kInstance(
TypeType(BuiltinsArena(), DynType()));
Expand Down
2 changes: 1 addition & 1 deletion common/values/custom_list_value_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ using ::testing::Optional;
using ::testing::Pair;
using ::testing::UnorderedElementsAre;

struct CustomListValueTest;
class CustomListValueTest;

struct CustomListValueTestContent {
google::protobuf::Arena* absl_nonnull arena;
Expand Down
2 changes: 1 addition & 1 deletion common/values/custom_map_value_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ using ::testing::Optional;
using ::testing::Pair;
using ::testing::UnorderedElementsAre;

struct CustomMapValueTest;
class CustomMapValueTest;

struct CustomMapValueTestContent {
google::protobuf::Arena* absl_nonnull arena;
Expand Down
2 changes: 1 addition & 1 deletion common/values/custom_struct_value_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ using ::testing::NotNull;
using ::testing::Pair;
using ::testing::UnorderedElementsAre;

struct CustomStructValueTest;
class CustomStructValueTest;

struct CustomStructValueTestContent {
google::protobuf::Arena* absl_nonnull arena;
Expand Down
2 changes: 1 addition & 1 deletion eval/eval/logic_step_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ class LogicStepTest : public testing::TestWithParam<bool> {
}

private:
absl_nonnull std::shared_ptr<class RuntimeEnv> env_;
absl_nonnull std::shared_ptr<const RuntimeEnv> env_;
Arena arena_;
};

Expand Down
3 changes: 0 additions & 3 deletions internal/number_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
namespace cel::internal {
namespace {

constexpr double kNan = std::numeric_limits<double>::quiet_NaN();
constexpr double kInfinity = std::numeric_limits<double>::infinity();

TEST(Number, Basic) {
EXPECT_GT(Number(1.1), Number::FromInt64(1));
EXPECT_LT(Number::FromUint64(1), Number(1.1));
Expand Down