Make CustomMapValueInterface::arena nullable.
#1715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_811678329
branch
2 times, most recently
from
15fe0d2 to
cf0f1ea
Compare
Default `CustomMapValue` constructor sets `arena` to `nullptr`, and then there is no code which relies on `nonnull` of the the `arena` pointer. PiperOrigin-RevId: 811842550
copybara-service
bot
force-pushed
the
test_811678329
branch
from
cf0f1ea to
bf25fa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
CustomMapValueInterface::arenanullable.Default
CustomMapValueconstructor setsarenatonullptr,and then there is no code which relies on
nonnullof thethe
arenapointer.