[checker] Fix bug where recursive type could be inferred #1738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_817287593
branch
2 times, most recently
from
79bc97f to
c422916
Compare
The cycle check during inference had a bug where certain recursive definitions could be inferred. This would lead to the checker eventually crashing when it tried to realize a concrete type from the substitution map. ex. `[optional.none()].map(x, [?x, null, x])` PiperOrigin-RevId: 817307359
copybara-service
bot
force-pushed
the
test_817287593
branch
from
c422916 to
033986e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[checker] Fix bug where recursive type could be inferred
The cycle check during inference had a bug where certain recursive definitions
could be inferred. This would lead to the checker eventually crashing when it
tried to realize a concrete type from the substitution map.
ex.
[optional.none()].map(x, [?x, null, x])