Catchup export from google #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 200304489
kyessenov
pushed a commit
that referenced
this pull request
Dec 9, 2019
-- 284576129: BEGIN_PUBLIC Define an abstract class for Activation. This would be used by a Wasm context to implement FindValue, as opposed to maintaining an embedded Activation. Values have unmanaged lifetimes, meaning if it difficult to add/remove values from an Activation repeatedly. END_PUBLIC -- 284290583: Migrate existing users of the tools/build_defs/golden_test macros to use the new macro location. This CL is supposed to be a no-op, and https://paste.googleplex.com/5747263567560704?raw shows it will be. If I've messed up, or e.g. an intervening depot CL means something unexpected happens, that's fine; please fix-forward. This CL is #2 out of 3 in http://b/145011071#comment2. Tested: TAP --sample ran all affected tests and none failed http://test/OCL:283986728:BASE:284250161:1575670327474:2f203dc8 -- 284044257: BEGIN_PUBLIC Fix parsing bug with raw strings (e.g. r""). Switch conformance tests to use C++ parser instead of Go parser. END_PUBLIC PiperOrigin-RevId: 284576129
kyessenov
added a commit
that referenced
this pull request
Dec 9, 2019
-- 284576129: BEGIN_PUBLIC Define an abstract class for Activation. This would be used by a Wasm context to implement FindValue, as opposed to maintaining an embedded Activation. Values have unmanaged lifetimes, meaning if it difficult to add/remove values from an Activation repeatedly. END_PUBLIC -- 284290583: Migrate existing users of the tools/build_defs/golden_test macros to use the new macro location. This CL is supposed to be a no-op, and https://paste.googleplex.com/5747263567560704?raw shows it will be. If I've messed up, or e.g. an intervening depot CL means something unexpected happens, that's fine; please fix-forward. This CL is #2 out of 3 in http://b/145011071#comment2. Tested: TAP --sample ran all affected tests and none failed http://test/OCL:283986728:BASE:284250161:1575670327474:2f203dc8 -- 284044257: BEGIN_PUBLIC Fix parsing bug with raw strings (e.g. r""). Switch conformance tests to use C++ parser instead of Go parser. END_PUBLIC PiperOrigin-RevId: 284576129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 200304489