Should transform "x ? true : false" into "!!x" and "x ? false : true" into "!x"

[TomasRiker]

With the latest release (v20250820):

window.f = x => x ? true : false;

gets transformed into

window.f=a=>a?!0:!1;

A shorter (and to my knowledge, equivalent) expression would be:

window.f=a=>!!a;

Similarly,

window.f = x => x ? false : true;

should be transformed into

window.f=a=>!a;

[lauraharker]

Thanks for the report.

Debugger link: closure-compiler-debugger.appspot.com

Seems like a valid improvement.

I would expect this to happen in one of the peephole passes, such as https://github.com/google/closure-compiler/blob/c7a98f442b185b3eafec68ca06d3c4842b85eae6/src/com/google/javascript/jscomp/PeepholeMinimizeConditions.java.

[lauraharker]

Note - while discussing this during triage, we noticed https://github.com/google/closure-compiler/blob/c7a98f442b185b3eafec68ca06d3c4842b85eae6/src/com/google/javascript/jscomp/PeepholeMinimizeConditions.java has some code trying to handle ternaries -

it might only target ternaries in conditional checks though, since those automatically get coerced to booleans