Skip to content

Add externs for the W3C's Touch Events Extensions specification #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MatrixFrog merged 3 commits into from
Sep 15, 2015
Merged

Add externs for the W3C's Touch Events Extensions specification #1140

MatrixFrog merged 3 commits into from
Sep 15, 2015

Conversation

@fredj
Copy link
Contributor

@fredj fredj commented Sep 14, 2015

No description provided.

@MatrixFrog
Copy link
Contributor

MatrixFrog commented Sep 14, 2015

If this is (or is expected to be) an official w3c spec it can probably go in externs rather than contrib/externs. (It looks like Touch itself is defined in a file called iphone.js but it sounds like the API is actually implemented on Android browsers as well, so we should rename that at some point.)

@ChadKillingsworth
Copy link
Collaborator

ChadKillingsworth commented Sep 14, 2015

A quick scan of the iphone.js file leads me to think that almost everything in there should be moved to other files.

@ChadKillingsworth
Copy link
Collaborator

ChadKillingsworth commented Sep 14, 2015

@fredj If you'd like to move the Touch events out of iphone.js and into /externs/browser/touchevents.js, you can add your changes to that.

Official spec for touch events: http://www.w3.org/TR/touch-events/

@fredj fredj force-pushed the touch-events-extensions branch from 8e388db to 87db305 Compare September 15, 2015 07:20
@fredj
Copy link
Contributor Author

fredj commented Sep 15, 2015

I've moved out the touch events from iphone.js to w3c_touch_event.js and added the Touch Events Extensions stuff to that file.

I've also added the prefixed (webkit) Touch Events Extensions properties to iphone.js

@fredj
Fix TouchList#item return type
6ddcc3f 
From the spec (http://www.w3.org/TR/touch-events/#widl-TouchList-item-getter-Touch-unsigned-long-index):

returns the Touch at the specified index in the list or null if the
index is not less than the length of the list.
MatrixFrog added a commit that referenced this pull request Sep 15, 2015
@MatrixFrog
Merge pull request #1140 from fredj/touch-events-extensions
628e1c5 
Add externs for the W3C's Touch Events Extensions specification
@MatrixFrog MatrixFrog merged commit 628e1c5 into google:master Sep 15, 2015
@fredj fredj deleted the touch-events-extensions branch September 16, 2015 04:24
fredj added a commit to fredj/openlayers that referenced this pull request Sep 24, 2015
@fredj
Remove externs in externs/closure-compiler.js
7252227 
Fixed upstream:
 * google/closure-compiler#1139
 * google/closure-compiler#1140
@fredj fredj mentioned this pull request Sep 24, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fredj @MatrixFrog @ChadKillingsworth @googlebot