Use container labels to get container ID on GitLab #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Will this work for non-self-hosted runners? |
Collaborator
|
Thanks for this btw |
Contributor
Author
|
As far as I know the only supported mode with GitLab.com SaaS Runners is Docker-in-Docker. These runners don't provide access to docker.sock other than with Docker-in-Docker, as can be seen in https://gitlab.com/securitykernel/cflite-example. |
Contributor
Author
|
Maybe I was not clear enough here. The change is not relevant for non -self hosted runners, because the variable is not used there anyway. |
Collaborator
|
Sorry for not merging this earlier. |
Collaborator
Ah maybe I shouldn't have merged this...might revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently updated a self-hosted GitLab Runner from Ubuntu 20.04 to 22.04 and noticed that all fuzzing jobs failed because
cut -c9- < /proc/1/cpusetwhich we use to populateCFL_CONTAINER_IDreturns an empty string.Instead, use docker container labels set by GitLab Runner to get the running container ID. Solution found via Stack Overflow.
Also harmonizes case sensitivity for all mentioning of GitLab.