Migrate actions to Ubuntu 24.04-v1 #146
Conversation
| runs: | ||
| using: 'docker' | ||
| image: 'docker://gcr.io/oss-fuzz-base/clusterfuzzlite-build-fuzzers:v1' | ||
| image: 'docker://gcr.io/oss-fuzz-base/clusterfuzzlite-build-fuzzers:ubuntu-24-04-v1' |
There was a problem hiding this comment.
FWIW I'm not sure how safe it is to change it here. As far as I can remember the v1 tag used by projects using CFLite was updated automatically and I don't think it should start pointing at these versions automatically (because it can just break stuff that doesn't work with Ubuntu 24.04 yet. For example avahi fails under MSan on Ubuntu 24.04 (avahi/avahi#787) so I'd keep Ubuntu 20.04 there for now).
(If it doesn't affect the v1 tag and another tag is going to be added instead it should be fine of course)
There was a problem hiding this comment.
Just to clarify I mean https://github.com/google/clusterfuzzlite/tags and things like
google/clusterfuzzlite/actions/build_fuzzers@v1used in actions https://google.github.io/clusterfuzzlite/running-clusterfuzzlite/github-actions/#pr-fuzzing.
Projects pulling main instead of v1 probably know what they're doing so they probably should be fine with breaking changes.
There was a problem hiding this comment.
I understand your concern. The plan here is to re-release v1 specifically with the fix from google/oss-fuzz#14388. The default fallback behavior will remain ubuntu-20-04. So, unless someone explicitly changes base_os_version to ubuntu-24-04 in project.yaml, it will continue running on ubuntu-20-04. We can set the default to ubuntu-24-04 in v2 (or on the main branch) once the migration is complete.
There was a problem hiding this comment.
I'm also worried about this, but your explanation makes sense.
There was a problem hiding this comment.
Agreed. It makes sense. I guess I thought that it would start pulling ubuntu-24-04 left and right but it isn't the case. As long as ubuntu-20-04 is used by default it should be fine then.
| runs: | ||
| using: 'docker' | ||
| image: 'docker://gcr.io/oss-fuzz-base/clusterfuzzlite-run-fuzzers:v1' | ||
| image: 'docker://gcr.io/oss-fuzz-base/clusterfuzzlite-run-fuzzers:ubuntu-24-04-v1' |
There was a problem hiding this comment.
Is this change safe to make? Or do we pivot back to 20 if they aren't opting into 24?
The ubuntu-24-04 images are built now (google/oss-fuzz#14382) and the issue where the PROJECT_SRC_PATH kludge had to be added is addressed in google/oss-fuzz#14388. It can be merged once the action starts fetching the ubuntu-24-04 images in google/clusterfuzzlite#146.
3 participants
This PR updates the build and run actions to use the new Ubuntu 24.04-v1 images.
This is part of the migration of OSS-Fuzz and ClusterFuzzLite to Ubuntu 24.04. The images have been prepared in the oss-fuzz repository and are ready for use.