Simplify imports by importing fewer items directly #2404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the code without an IDE, I find it useful to use explicit
module names, especially when items come from the standard library.
So
io::Errorinstead of justError, especially when people havejust been told about
std::error::Erroras well.I also omitted most single-use items: I find it has less cognitive
overhead to say “we import
fmt” and then later usefmt::Displayand
fmt::Formatterin the code. It’s clear from the name that thesetwo things have something to do with formatting.
Finally, I made a few usages more consistent so that we refer to each
item in the same way within a single codeblock.