Wrap assembly comments consistently #2430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some lines were much longer than others. They are now consistently wrapped at 70 columns. Why so short, why not 80 or 90? Because we sometimes need to browse these files during class, and there we don’t have a lot of horizontal space when using large fonts.
mgeisler
commented
Nov 19, 2024
mgeisler
commented
Nov 19, 2024
The other comments are apparently indented using tabs, so that's what I used here as well.
michael-kerscher
approved these changes
Nov 22, 2024
Collaborator
michael-kerscher
left a comment
michael-kerscher
left a comment
There was a problem hiding this comment.
The commit looks good to me. There are differences in the indentation style (tabs vs spaces) though.
| /* | ||
| * Load and apply the memory management configuration, ready to enable MMU and | ||
| * caches. | ||
| * Load and apply the memory management configuration, ready to |
Collaborator
There was a problem hiding this comment.
these are spaces to indent, files below have tabs. Should we try to have one style over all files?
This could also be a separate commit
Collaborator
Author
There was a problem hiding this comment.
Yeah, having a consistent style would be good! Perhaps we could teach dprint to do this, but it might not be worth is since we touch these files very very rarely.
HidenoriKobayashi
pushed a commit
to HidenoriKobayashi/comprehensive-rust
that referenced
this pull request
Nov 25, 2024
Some lines were much longer than others. They are now consistently wrapped at 70 columns. Why so short, why not 80 or 90? Because we sometimes need to browse these files during class, and there we don’t have a lot of horizontal space when using large fonts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some lines were much longer than others. They are now consistently
wrapped at 70 columns. Why so short, why not 80 or 90? Because we
sometimes need to browse these files during class, and there we don’t
have a lot of horizontal space when using large fonts.