Remove silence warnings in exercises #391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused code warning #71
cchiw
changed the title
mgeisler
requested changes
Feb 28, 2023
cchiw
changed the title
… into cchiw-patch-11
… into cchiw-patch-11
… into cchiw-patch-11
mgeisler
reviewed
Mar 19, 2023
| #: src/exercises/day-2/health-statistics.md:13 | ||
| msgid "" | ||
| "```rust,should_panic\n" | ||
| "// TODO: remove this when you're done with your implementation.\n" |
Collaborator
There was a problem hiding this comment.
Please don't modify the .po files — only the translators can update those.
mgeisler
reviewed
Mar 19, 2023
|
|
||
| impl User { | ||
| pub fn new(name: String, age: u32, weight: f32) -> Self { | ||
| println!("Use name {:?} age {:?} and weight{:?}", name, age, weight); |
Collaborator
There was a problem hiding this comment.
I've tried to inline the format strings everywhere else in the course:
Suggested change
| println!("Use name {:?} age {:?} and weight{:?}", name, age, weight); | |
| println!("Use name {name:?} age {age:?} and weight {weight:?}"); |
I also fixed a space, which makes me think that you've not looked at this in the browser after making the change?
mgeisler
reviewed
Mar 19, 2023
| } | ||
|
|
||
| pub fn name(&self) -> &str { | ||
| println!("Use name {:?}", self.name); |
Collaborator
There was a problem hiding this comment.
I don't know if we've agreed that this is a good way to "fix" the warnings? I would have added such print statements already if this is a nice way to solve it 🙂
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code had variables in the function arguments that were not being used (yet).
To address that, in this PR I use the function arguments in a print statement. This changes allow us to remove the line to silence warnings for unused variables #71.
Alternatively, we could comment out the functions. As seen in #389.