Remove silenced warnings in string-iterators exercise #392
Conversation
Please move this to the PR title. The title shows up prominently in the history afterwards so it's helpful when it says more than just "Update foo.md" 🙂 Also, please explain why you make the change. What did you see before and after this PR? That gives me a lot more context as a reviewer. |
cchiw
changed the title
cchiw
changed the title
| #![allow(unused_variables, dead_code)] | ||
|
|
||
| {{#include strings-iterators.rs:prefix_matches}} | ||
| pub fn prefix_matches(prefix: &str, request_path: &str) -> bool { |
There was a problem hiding this comment.
Doing this makes us lose the coupling with the function signature in strings-iterators.rs. Could you put the include back so that we can keep the connection?
There was a problem hiding this comment.
Sure, does it make sense to add a new function to the original string-iterators.rs file and refer to it in this file or just add the line back in as is? The commit I just made does the former.
There was a problem hiding this comment.
The latter is better: that way we avoid duplication in the solution file and we avoid showing prefix_matches_unimplemented to the students (there is no reason for them to see such a function name).
My goal is to reuse as much as possible from the solution file. We compile the code there in CI so we know it works — when we reuse it, we also have some confidence that the unsolved version is aligned with the solution.
2 participants
This code had variables in the function arguments that were not being used (yet).
To address that, in this PR I use the function arguments in a print statement. This changes allow us to remove the line to silence warnings for unused variables #71.
Alternatively, we could comment out the functions. As seen in #389.