lookupByKey corrections #4007
Merged
lookupByKey corrections #4007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please have a look (or rebase to) e1f8037 where I already fixed a few issues. |
# Conflicts: # src/idl_gen_general.cpp
|
Fixed typo, added checking before appending byte array. |
src/idl_gen_general.cpp
Outdated
| } | ||
| if (struct_def.has_key) { | ||
| if (struct_def.has_key && (lang_.language == IDLOptions::kJava || | ||
| lang_.language == IDLOptions::kCSharp)) { |
There was a problem hiding this comment.
what does this do? it currently only really runs for 2 languages.
There was a problem hiding this comment.
When the Go version will be released, absence of this check will cause errors. Remove it?
There was a problem hiding this comment.
The Go version will never be merged into this I don't think, so yes, remove it.
There was a problem hiding this comment.
Oh, yes, dumb checking. Sorry for that.
|
That typo would have been caught if there was a test for it... |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.