Skip to content

Conversation

@yahia3200
Copy link
Contributor

Description

Get rid of using the hatch system and instead use MANIFEST.in file which is compatible with setuptools system

Changes Made

  • remove hatch.build section from pyproject.toml file
  • add MANIFEST.in file to exclude test files

Related Issues

#186

Copy link
Contributor

@mshudrak mshudrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I requested some changes PTAL.

MANIFEST.in Outdated
@@ -0,0 +1 @@
exclude src/gcp_scanner/test_*.py No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line please.

@mshudrak mshudrak merged commit 3c3023f into google:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants