Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updates to Marketplace-related webhooks and REST APIs #1040

Closed
gmlewis opened this issue Nov 3, 2018 · 11 comments

Comments

@gmlewis
Copy link
Collaborator

commented Nov 3, 2018

GitHub Developer API announcement:
https://developer.github.com/changes/2018-10-31-improved-experience-for-marketplace-pending-changes/

This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started.

Thank you!

@srmocher

This comment has been minimized.

Copy link
Collaborator

commented Nov 3, 2018

@gmlewis New contributor here. Interested in working on this, could you assign this issue to me?

@gmlewis

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 3, 2018

Thank you, @srmocher!
I'm no longer able to send a repo contributor invite to you, but please consider yourself assigned. 😄

@dreamer-89

This comment has been minimized.

Copy link
Collaborator

commented Nov 3, 2018

@gmlewis : I am also interested to work on this issue. It seems @srmocher working on this one. Can you please assign me other issues/bugs ?

@gmlewis

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 3, 2018

Thanks for your interest, @dreamer-89!

My recommendation to you is to go through the list of open issues in this repo and choose one that interests you... then add a comment that you want to work on it. (I just browsed through and there are a bunch of outstanding ones.)

If someone is already listed on it, chances are high that they have forgotten about it and you can ask to take it over from them.

@dreamer-89

This comment has been minimized.

Copy link
Collaborator

commented Nov 3, 2018

Thank you so much @gmlewis :) :)

@dreamer-89

This comment has been minimized.

Copy link
Collaborator

commented Nov 4, 2018

@gmlewis : Please review
#1041

@gmlewis

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 4, 2018

@dreamer-89 - sorry I wasn't clear before... you apparently misunderstood me. This issue is assigned to @srmocher and so you should not be submitting PRs against this issue. I started to review your PR and came across a number of issues (both with the PR and with the GitHub documentation), then came back here and realized that this issue is not yours (currently) to be working on.

As a result, I'm going to close your PR and let's give @srmocher a chance to submit a PR against this issue.

Thank you very much for your enthusiasm, but please go back through the list of other open issues and chose one of those to start contributing to. If it is already assigned (like this one... you have to read the comments to determine that, unfortunately, as I no longer have permissions in this repo to send contributor invites), please first ask if you can take over the issue, but only if they've had a fair amount of time (a week or two maybe) to work on it.

@gmlewis

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 4, 2018

Note that to fully support this issue, there is a wealth of information located here:
https://developer.github.com/apps/marketplace/integrating-with-the-github-marketplace-api/github-marketplace-webhook-events/
that needs to be read and understood.

Specifically, any newly-created model structs should fully document the possible values of enumerated string fields (e.g. state).

@willnorris

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

(invites sent to @srmocher and @dreamer-89. sorry about the delay)

gmlewis added a commit that referenced this issue Nov 22, 2018
@sinisterstuf

This comment has been minimized.

Copy link

commented Oct 1, 2019

If this issue is resolved by #1042 then we could close it. Or is there something that still needs doing here?

@gmlewis

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 1, 2019

Thank you, @sinisterstuf - I believe you are correct that this can be closed.
Feel free to reopen if anyone disagrees.

@gmlewis gmlewis closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.