github.App: Use *Timestamp instead of *time.Time#1179
Merged
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1179 +/- ##
=======================================
Coverage 70.25% 70.25%
=======================================
Files 84 84
Lines 5867 5867
=======================================
Hits 4122 4122
Misses 956 956
Partials 789 789
Continue to review full report at Codecov.
|
gmlewis
approved these changes
May 31, 2019
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Ah, yes. Thank you, @aidansteele!
LGTM.
Awaiting second LGTM before merging.
Note to self: This is a breaking API change and we will need to bump the release version after this gets in.
Collaborator
|
Thank you, @vaibhavsingh97! Note to self: this is a breaking API change so we will bump the major version after merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a similar issue to #965 - the
created_atandupdated_atfields in theappfield of webhooks are formatted as Unix epoch integers, rather than RFC3339 for the CRUD APIs.