Skip to content

Add test cases for JSON resource marshaling#1989

Merged
gmlewis merged 1 commit into
google:masterfrom
sagar23sj:test-cases/orgs_actions_allowed
Jul 13, 2021
Merged

Add test cases for JSON resource marshaling#1989
gmlewis merged 1 commit into
google:masterfrom
sagar23sj:test-cases/orgs_actions_allowed

Conversation

@sagar23sj
Copy link
Copy Markdown
Contributor

Resource Covered : ActionsAllowed

Helps with issue: #55

@google-cla google-cla Bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 12, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 12, 2021

Codecov Report

Merging #1989 (f6ebd46) into master (f47f8fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1989   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files         105      105           
  Lines        6809     6809           
=======================================
  Hits         6662     6662           
  Misses         80       80           
  Partials       67       67           
Impacted Files Coverage Δ
github/checks.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f47f8fe...f6ebd46. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sagar23sj !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp July 12, 2021 19:17
Copy link
Copy Markdown

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis gmlewis merged commit 6e279e3 into google:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants