Add New Github Code scanning Alert fields#2013
Conversation
Co-authored-by: Stephen <stephengroat@users.noreply.github.com>
Co-authored-by: Stephen <stephengroat@users.noreply.github.com>
google-cla
Bot
added
the
cla: yes
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Whups, I see now that it is a draft... sorry for the early code review. Ah, well... hopefully some of the comments are useful to you.
Also, I'm confused by the description of this PR...
I would have named it something like Add missing Alert fields. Maybe you can clarify what is deprecated.
Oh, and finally, please remember to run gofmt on your edited files. Thanks.
ganeshkumarsv
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2013 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 107 107
Lines 6897 6897
=======================================
Hits 6750 6750
Misses 81 81
Partials 66 66
Continue to review full report at Codecov.
|
|
@gmlewis Yes, the PR is in draft right now. Thanks a lot anyways for your review comments. I have changed the desciption of the PR to |
ganeshkumarsv
changed the title
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @ganeshkumarsv - just a few minor tweaks, please.
|
@gmlewis Thanks a lot for the round 2 review comments. I guess I've addressed them. Please let me know if there is anything left to change. :) |
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @ganeshkumarsv !
LGTM.
Merging.
2 participants
This PR adds new fields to the Github Code scanning
Alertstruct to keep the client library updated with the new Github API response.Github API: https://docs.github.com/en/rest/reference/code-scanning#list-code-scanning-alerts-for-a-repository