Skip to content

Add test cases to verify that error responses contain status code#2093

Merged
gmlewis merged 2 commits into
google:masterfrom
AGMETEOR:fix-912
Sep 13, 2021
Merged

Add test cases to verify that error responses contain status code#2093
gmlewis merged 2 commits into
google:masterfrom
AGMETEOR:fix-912

Conversation

@AGMETEOR
Copy link
Copy Markdown
Contributor

Fixes #912

@google-cla google-cla Bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Sep 13, 2021
@AGMETEOR
Copy link
Copy Markdown
Contributor Author

Hi @gmlewis , I hope you has a great weekend. Here's the PR for issue 912

Copy link
Copy Markdown
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 13, 2021

Codecov Report

Merging #2093 (27f7970) into master (a0448fc) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2093      +/-   ##
==========================================
+ Coverage   97.75%   97.77%   +0.02%     
==========================================
  Files         107      109       +2     
  Lines        9600     9724     +124     
==========================================
+ Hits         9384     9508     +124     
  Misses        150      150              
  Partials       66       66              
Impacted Files Coverage Δ
github/event.go 100.00% <0.00%> (ø)
github/messages.go 100.00% <0.00%> (ø)
github/actions_runner_groups.go 100.00% <0.00%> (ø)
github/actions_workflow_runs.go 100.00% <0.00%> (ø)
github/orgs_hooks_deliveries.go 100.00% <0.00%> (ø)
github/repos_community_health.go 100.00% <0.00%> (ø)
github/repos_autolinks.go 100.00% <0.00%> (ø)
github/scim.go 100.00% <0.00%> (ø)
github/repos.go 98.64% <0.00%> (+<0.01%) ⬆️
github/github.go 97.58% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0448fc...27f7970. Read the comment docs.

Comment thread github/github_test.go Outdated
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AGMETEOR !
LGTM.
Thank you, also, @cpanato for the review! We appreciate it.
Merging.

@gmlewis gmlewis merged commit 9f7c203 into google:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error codes for failed repo webhook requests are "Unknown"

3 participants