Add new RemoveMilestone method on IssuesService#2195
Merged
Conversation
google-cla
Bot
added
the
cla: yes
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #2195 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 112 112
Lines 9976 9990 +14
=======================================
+ Hits 9755 9769 +14
Misses 154 154
Partials 67 67
Continue to review full report at Codecov.
|
gmlewis
changed the title
gmlewis
requested changes
Nov 2, 2021
gmlewis
changed the title
cpanato
reviewed
Nov 3, 2021
Contributor
cpanato
left a comment
cpanato
left a comment
There was a problem hiding this comment.
i'm not a maintainer of this project, but Glenn already did a great job reviewing this pr
besides that LGTM after the comments being addressed
thanks for working on this!
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Contributor
Author
|
Hi @gmlewis . I have made updates. Kindly requesting for another review. |
gmlewis
requested changes
Nov 3, 2021
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #236