Skip to content

Support OIDC subject claim customization templates for actions#2615

Merged
gmlewis merged 3 commits into
google:masterfrom
F21:actions-oidc
Jan 5, 2023
Merged

Support OIDC subject claim customization templates for actions#2615
gmlewis merged 3 commits into
google:masterfrom
F21:actions-oidc

Conversation

@F21
Copy link
Copy Markdown
Contributor

@F21 F21 commented Jan 3, 2023

Closes #2614

Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @F21 !
Just a few tweaks and questions, please.

Comment thread github/actions_oidc.go Outdated
Comment thread github/actions_oidc.go Outdated
Comment thread github/actions_oidc.go Outdated
Comment thread github/actions_oidc.go Outdated
Comment thread github/actions_oidc.go Outdated
Comment thread github/actions_oidc.go Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 4, 2023

Codecov Report

Merging #2615 (0d02761) into master (c5583e7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2615   +/-   ##
=======================================
  Coverage   97.99%   98.00%           
=======================================
  Files         127      128    +1     
  Lines       10948    10977   +29     
=======================================
+ Hits        10729    10758   +29     
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/actions_oidc.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 4, 2023
Comment thread github/actions_oidc.go
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @F21 !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@F21
Copy link
Copy Markdown
Contributor Author

F21 commented Jan 4, 2023

Thanks so much for the quick review, @gmlewis !

Copy link
Copy Markdown
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented Jan 5, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit 93166f4 into google:master Jan 5, 2023
@F21 F21 deleted the actions-oidc branch January 5, 2023 21:15
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support setting customization template for OIDC subject claims in GitHub Actions

3 participants