Add method to update codescanning alert#2639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2639 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 130 130
Lines 11242 11257 +15
=======================================
+ Hits 11023 11038 +15
Misses 150 150
Partials 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
be4a2a0 to
308750d
Compare
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @ganeshkumarsv !
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
left a comment
There was a problem hiding this comment.
Can you please run gofmt on the newly-changed files and also make sure to run "go generate ./..." and push the changed files to this PR to get all the tests to pass?
gmlewis
left a comment
There was a problem hiding this comment.
Oh, and of course, please run "go test ./..." to catch the error in the test file.
|
Thanks for the commit suggestion @gmlewis I fixed the test cases and generators. |
gmlewis
left a comment
There was a problem hiding this comment.
Sorry, @ganeshkumarsv - it looks like I made a couple mistakes in my suggestions.
Just a few minor tweaks, please.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @ganeshkumarsv !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
@gmlewis we got 2 approvals on the PR. can you please merge the PR and create a new release? |
Yes, but as for the new release, we already have breaking API changes and I would like to get #2646 approved and committed too before the major version change, so if you feel like reviewing that one, @ganeshkumarsv , that would speed the process along. Thanks. |
|
Thank you, @AbbanMustafa ! |
|
@ganeshkumarsv - this is now available in the v50.0.0 release: https://github.com/google/go-github/releases/tag/v50.0.0 |
Adds method to update codescanning alert.
https://docs.github.com/en/rest/code-scanning?apiVersion=2022-11-28#update-a-code-scanning-alert