fix!: Add field PerPage to OrganizationsListOptions#3986
fix!: Add field PerPage to OrganizationsListOptions#3986gmlewis merged 2 commits intogoogle:masterfrom
PerPage to OrganizationsListOptions#3986Conversation
|
Created issue #3987 about failing |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear!
And yes, there will be inconsistencies in this repo with the handling of url: struct tags. We should probably work on making them consistent and NOT use pointers for these values, which would also help to make it clearer what is a URL param and what is not.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3986 +/- ##
==========================================
- Coverage 93.53% 93.52% -0.01%
==========================================
Files 207 207
Lines 17610 17593 -17
==========================================
- Hits 16471 16454 -17
Misses 938 938
Partials 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Excellent! Thank you, @alexandear!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
Thank you, @Not-Dhananjay-Mishra! |
BREAKING CHANGE:
OrganizationsListOptionsnow contains onlyPerPageinstead ofListOptions.Updates #3976
We could build an iterator for
ListAllusing theSincefield, but it is not very useful.ListAllIterwould return all organizations across GitHub, which is a large result set.