Skip to content

fix!: Add field PerPage to OrganizationsListOptions#3986

Merged
gmlewis merged 2 commits intogoogle:masterfrom
alexandear-org:fix/organizations-list-all
Feb 10, 2026
Merged

fix!: Add field PerPage to OrganizationsListOptions#3986
gmlewis merged 2 commits intogoogle:masterfrom
alexandear-org:fix/organizations-list-all

Conversation

@alexandear
Copy link
Contributor

@alexandear alexandear commented Feb 10, 2026

BREAKING CHANGE: OrganizationsListOptions now contains only PerPage instead of ListOptions.

Updates #3976

We could build an iterator for ListAll using the Since field, but it is not very useful. ListAllIter would return all organizations across GitHub, which is a large result set.

@alexandear
Copy link
Contributor Author

Created issue #3987 about failing TestDo_rateLimit_abuseRateLimitError_xRateLimitReset.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!

And yes, there will be inconsistencies in this repo with the handling of url: struct tags. We should probably work on making them consistent and NOT use pointers for these values, which would also help to make it clearer what is a URL param and what is not.

@alexandear alexandear requested a review from gmlewis February 10, 2026 15:54
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (e5024aa) to head (485d0ac).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3986      +/-   ##
==========================================
- Coverage   93.53%   93.52%   -0.01%     
==========================================
  Files         207      207              
  Lines       17610    17593      -17     
==========================================
- Hits        16471    16454      -17     
  Misses        938      938              
  Partials      201      201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you, @alexandear!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @zyfy29 - @Not-Dhananjay-Mishra

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Feb 10, 2026
Copy link
Contributor

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Feb 10, 2026
@gmlewis
Copy link
Collaborator

gmlewis commented Feb 10, 2026

Thank you, @Not-Dhananjay-Mishra!
Merging.

@gmlewis gmlewis merged commit c5bf1bc into google:master Feb 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments